Skip to content

Comments

[core] Mask serve directory for core tests#50609

Merged
aslonnie merged 1 commit intoray-project:masterfrom
edoakes:eoakes/mask-serve-dir
Feb 14, 2025
Merged

[core] Mask serve directory for core tests#50609
aslonnie merged 1 commit intoray-project:masterfrom
edoakes:eoakes/mask-serve-dir

Conversation

@edoakes
Copy link
Collaborator

@edoakes edoakes commented Feb 14, 2025 •
edited
Loading

Why are these changes needed?

Remove python/ray/serve/ directory during core tests to enforce componentization.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes
fix
7e77851 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Feb 14, 2025
@edoakes edoakes requested a review from aslonnie February 14, 2025 17:25
aslonnie
aslonnie approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


via GIPHY

@aslonnie aslonnie merged commit baadbd3 into ray-project:master Feb 14, 2025
4 checks passed
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@edoakes
[core] Mask serve directory for core tests (ray-project#50609)
fb2bcaf 
Remove python/ray/serve/ directory during core tests to enforce componentization.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@edoakes
[core] Mask serve directory for core tests (ray-project#50609)
8f92c30 
Remove python/ray/serve/ directory during core tests to enforce componentization.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
park12sj pushed a commit to park12sj/ray that referenced this pull request Mar 18, 2025
@edoakes @park12sj
[core] Mask serve directory for core tests (ray-project#50609)
6b17ea5 
Remove python/ray/serve/ directory during core tests to enforce componentization.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@abrarsheikh abrarsheikh mentioned this pull request Jun 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aslonnie aslonnie aslonnie approved these changes

Assignees

No one assigned

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edoakes @aslonnie @hainesmichaelc